Add managed previews for Links and Markdown library editors - #288213
Draft
nickpeihl wants to merge 1 commit into
Draft
Add managed previews for Links and Markdown library editors#288213nickpeihl wants to merge 1 commit into
nickpeihl wants to merge 1 commit into
Conversation
|
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds managed flyout editors with attached embeddable previews for Links and Markdown library items.
openLazySystemFlyoutwhile sharing lazy loading, overlay tracking, error handling, and focus restoration with the traditional flyout helperScreenshots
Visualize Library
Links
Narrow viewport, with the editor taking precedence:
Markdown
Narrow viewport, with the editor taking precedence:
Dashboard editors
Links
Markdown
Testing
node scripts/check.js --scope=stagedRelease note
Links and Markdown library items can now be edited from the Visualize Library with an attached live preview.
Checklist
Identify risks
The main risk is interaction between independently mounted system flyouts and the EUI Flyout Manager, especially during responsive layout changes. The implementation keeps React context intact, closes previews when the viewport narrows, guards async updates after unmount, and includes focused tests for the shared flyout and editor state behavior.